Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mast machine mapping #246

Merged
merged 10 commits into from
Aug 23, 2023
Merged

Mast machine mapping #246

merged 10 commits into from
Aug 23, 2023

Conversation

jmcclena
Copy link
Collaborator

This pull request adds initial machine mapping for MAST for constructing EFIT inputs

@jmcclena jmcclena added the WIP Work in progress label Apr 17, 2023
smithsp
smithsp requested changes Jun 5, 2023
View reviewed changes
Copy link
Member

@smithsp smithsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some odd nstx lingering in mast.py

omas/machine_mappings/mast.py Outdated Show resolved Hide resolved
omas/machine_mappings/mast.py Outdated Show resolved Hide resolved
omas/machine_mappings/mast.py Outdated Show resolved Hide resolved
omas/machine_mappings/mast.py Outdated Show resolved Hide resolved
omas/machine_mappings/mast.py Outdated Show resolved Hide resolved
omas/machine_mappings/mast.py Outdated Show resolved Hide resolved
@smithsp
Copy link
Member

smithsp commented Jun 20, 2023

@jmcclena You should merge master in here, to get the automatic COCOS conversions of error_upper that @bechtt implemented.

@jmcclena
Copy link
Collaborator Author

@bpatel2107

@jmcclena jmcclena removed the WIP Work in progress label Aug 3, 2023
@jmcclena jmcclena merged commit 70fc5d7 into master Aug 23, 2023
1 check passed
@jmcclena jmcclena deleted the mast_machine_mapping branch September 27, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smithsp smithsp smithsp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jmcclena @smithsp